Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: (BitcoinRBF-Step2): some minimum code refactoring for Bitcoin RBF adoption #3381

Merged
merged 48 commits into from
Feb 4, 2025
+2,719 −1,397

update changelog

6ece1c0
Select commit
Loading
Failed to load commit list.
Merged

refactor: (BitcoinRBF-Step2): some minimum code refactoring for Bitcoin RBF adoption #3381

update changelog
6ece1c0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 3, 2025 in 0s

65.28% (+0.87%) compared to 9106fe6

View this Pull Request on Codecov

65.28% (+0.87%) compared to 9106fe6

Details

Codecov Report

Attention: Patch coverage is 64.61538% with 230 lines in your changes missing coverage. Please review.

Project coverage is 65.28%. Comparing base (9106fe6) to head (6ece1c0).

Files with missing lines Patch % Lines
zetaclient/chains/bitcoin/observer/outbound.go 26.41% 77 Missing and 1 partial ⚠️
zetaclient/chains/bitcoin/observer/gas_price.go 0.00% 37 Missing ⚠️
zetaclient/chains/bitcoin/observer/utxos.go 80.00% 16 Missing and 7 partials ⚠️
zetaclient/chains/bitcoin/signer/sign.go 84.96% 16 Missing and 7 partials ⚠️
zetaclient/chains/bitcoin/signer/signer.go 56.25% 19 Missing and 2 partials ⚠️
zetaclient/chains/bitcoin/client/helpers.go 0.00% 18 Missing ⚠️
zetaclient/chains/bitcoin/observer/observer.go 58.82% 6 Missing and 1 partial ⚠️
zetaclient/chains/bitcoin/client/client.go 0.00% 5 Missing ⚠️
zetaclient/chains/bitcoin/signer/outbound_data.go 93.44% 3 Missing and 1 partial ⚠️
zetaclient/metrics/telemetry.go 0.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3381      +/-   ##
===========================================
+ Coverage    64.40%   65.28%   +0.87%     
===========================================
  Files          436      441       +5     
  Lines        30379    30429      +50     
===========================================
+ Hits         19566    19865     +299     
+ Misses        9972     9708     -264     
- Partials       841      856      +15
Files with missing lines Coverage Δ
zetaclient/chains/evm/observer/observer.go 70.28% <100.00%> (ø)
zetaclient/testutils/testdata.go 87.09% <100.00%> (+0.35%) ⬆️
zetaclient/testutils/testdata_naming.go 80.85% <100.00%> (+0.85%) ⬆️
zetaclient/zetacore/broadcast.go 59.16% <100.00%> (+0.34%) ⬆️
zetaclient/chains/bitcoin/common/fee.go 43.63% <89.47%> (+4.61%) ⬆️
zetaclient/chains/evm/signer/signer.go 41.56% <0.00%> (ø)
zetaclient/chains/bitcoin/observer/db.go 93.47% <93.47%> (ø)
zetaclient/tss/crypto.go 55.22% <50.00%> (-0.25%) ⬇️
zetaclient/chains/bitcoin/signer/outbound_data.go 93.44% <93.44%> (ø)
zetaclient/metrics/telemetry.go 0.00% <0.00%> (ø)
... and 8 more
View more details on Codecov