Properly format PHPDoc @method annotation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise PHPStan will complain with errors like: `Call to an undefined method Zend_View_Helper_Navigation::breadcrumbs().`
|
@holtkamp how do you test phpstan here? I guess it might need a heavily adjusted config in order to just get rid of the most obtrusive issues, instead of reformatting half of the framework code? (as it could be seen in other zf1-related repos) |
falkenhawk
approved these changes
Dec 13, 2019
|
Ah, did not see your question. On the road now so quick answer: PHPStan
runs in my own "user land" code. When the. Invoking functions as part of
ZF, these errors showed up due to incorrect PHPDoc formatting.
So I don't run PHPStan on ZF "itself"... Hope this explains it...
…On Fri, 13 Dec 2019, 11:41 Maciej Holyszko, ***@***.***> wrote:
Merged #13 <#13> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13?email_source=notifications&email_token=AAF5RVP5HQGD4GPWDUCAV23QYNREFA5CNFSM4IH3TN4KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVO3YF5I#event-2880930549>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF5RVML53SLZ7LXT3OOH7TQYNREFANCNFSM4IH3TN4A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise PHPStan will complain with errors like:
Call to an undefined method Zend_View_Helper_Navigation::breadcrumbs().