Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add monorepo-builder.yml and phpunit.xml.dist to export-ignore #134

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Oct 5, 2022

This prevents these files from being copied to zf1s/zf1 install.

@falkenhawk
Copy link
Member

falkenhawk commented Oct 6, 2022

Thanks for being proactive and paying attention to details :)
I suppose even more files/folders could be omitted:
.github
.gitignore

image

@glensc
Copy link
Contributor Author

glensc commented Oct 7, 2022

indeed, I didn't look ls -a. will check again.

and we could go even further and apply similar rules for packages/*

@glensc
Copy link
Contributor Author

glensc commented Oct 7, 2022

added your suggestion, and subpackages i think are fine:

➔ find -type f|grep -Ev '(\.php|composer.json|README.md|LICENSE.txt)$|Zend/Locale/Data|Zend/Queue/Adapter/Db/|resources/PhpOnAzure.Web/resources/WebPICmdLine/|Zend/Text/Figlet/zend-framework.flf|Scaffolders/DefaultScaffolder.phar|Scaffolders/DefaultScaffolder/resources|./zend-tool/bin/zf.sh|./zend-service-windowsazure/library/Zend/Service/WindowsAzure/CommandLine/Scaffolders/DefaultScaffolder/build.bat'

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

@falkenhawk falkenhawk merged commit 7292b9a into zf1s:master Oct 7, 2022
@falkenhawk falkenhawk mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants