[zend-form] fix instantiating filters with options via addFilter() in php 8.0+
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcing
changed the title
falkenhawk
reviewed
Feb 15, 2024
marcing
force-pushed
the
fix/php8-zend-form-element
branch
from
527acf7 to
c210df9
Compare
marcing
force-pushed
the
fix/php8-zend-form-element
branch
from
c210df9 to
26d082e
Compare
falkenhawk
changed the title
addFilter() in php 8.0+
falkenhawk
pushed a commit
that referenced
this pull request
Feb 25, 2024
…in php 8.0+ (#194) Copied logic from addValidator() to addFilter() which checks for array arguments and wraps them with additional array when necessary. It's interesting that `addValidator()` was made future-proof already long time ago (even before the github history goes) but `addFilter()` was not
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0+ changes behaviour of ReflectionClass::newInstanceArgs, which now assumes that an associative array is an array of named parameters, trying to match array keys to names of arguments in the constructor. This leads to errors in Zend_Form_Element::_loadFilter.
Zend_Form_Element::_loadFilter has to be altered in the same manner as _loadValidator to call newInstanceArgs only or numerical arrays and call newInstance on associative arrays.