Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Incompatiblity with standard Zend MVC, Zend module MVC #20

Closed
wants to merge 1 commit into from

Conversation

saru2048
Copy link

Hello.
Thanks for publishing this repository.
I found two bugs and fixed them, so I create a pull request.
Please consider it.

  • A request url, controller does not exist, it not got a 404 error.
  • Default/controllers/IndexController load fails when default module prefix is disabled
    • classname is IndexController
    • $front->prefixDefaultModule(false)

Regards,

@falkenhawk falkenhawk self-requested a review January 11, 2020 12:16
@falkenhawk
Copy link
Member

@saru2048 I have changed these class_exists calls in cadf3e0 because of apparently some issues with composer autoloader, which I don't remember exactly anymore :(

Too bad it broke the thing for you. But I am afraid changing it back may break composer autoloading again.

Could you maybe add a test case to reproduce this, please?

@falkenhawk
Copy link
Member

Fixed in #116 (most probably.)

@falkenhawk falkenhawk closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants