Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Zend_Validate_Barcode_IntelligentMail class name for psr-0 auto… #24

Merged
merged 4 commits into from
Aug 26, 2020

Conversation

marcing
Copy link
Contributor

@marcing marcing commented Aug 13, 2020

…loading compatibility

@falkenhawk
Copy link
Member

@marcing I wonder if it would make more sense to rename the file instead? 🤔

@falkenhawk
Copy link
Member

@marcing a test is failing

1) Zend_Validate_BarcodeTest::testINTELLIGENTMAIL

include_once(Intelligentmail.php): failed to open stream: No such file or directory
/home/travis/build/zf1s/zf1/packages/zend-loader/library/Zend/Loader.php:134
/home/travis/build/zf1s/zf1/packages/zend-loader/library/Zend/Loader.php:134
/home/travis/build/zf1s/zf1/packages/zend-loader/library/Zend/Loader.php:82
/home/travis/build/zf1s/zf1/packages/zend-validate/library/Zend/Validate/Barcode.php:137
/home/travis/build/zf1s/zf1/packages/zend-validate/library/Zend/Validate/Barcode.php:107
/home/travis/build/zf1s/zf1/tests/Zend/Validate/BarcodeTest.php:345

@marcing
Copy link
Contributor Author

marcing commented Aug 19, 2020

It would pass if the file was renamed like I proposed initially. @falkenhawk

@glensc
Copy link
Contributor

glensc commented Aug 19, 2020

@marcing you mean class rename, not file rename?

@marcing
Copy link
Contributor Author

marcing commented Aug 19, 2020

Yes I think the class should be renamed, because the adapter loading forces strtolower + ucfirst and the classname change won't work @glensc

@falkenhawk falkenhawk merged commit 514800d into master Aug 26, 2020
@falkenhawk falkenhawk deleted the fix/composer2-compatibility branch August 26, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants