-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore locales before calling test assertions #45
Conversation
b77aef4
to
708962a
Compare
708962a
to
20c8a01
Compare
#49 has been merged, so can rebase now to see that pdo tests will start to fail because they are not locale aware. |
20c8a01
to
1f84899
Compare
I'm unable to reproduce the "locales break float and create sql injection' problem. but I guess it's not that important anymore, as the code passes now. |
20211c5
to
862a0a8
Compare
9eafbd0
to
75d165c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very glad that you sorted this issue out
This is to clearly indicate specific encoding is expected
This ensures global state like locale is restored before throwing exceptions.
9942b93
to
4d0f809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glensc Is it safe to merge now? It looks good to me.
@falkenhawk do not remember. merge if it's ok with you. |
Restore locales before calling assertions otherwise sql will be broken:
From #34 (comment):
NOTE: fixing the DB layer to be independent on locale is a legacy that zf1 carries and can't be fixed.