Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8.0 to GitHub Actions ignoring its errors #59

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Feb 8, 2021

The example given in the documentation:

does not actually work as expected:

So, this uses the same "experimental: true" setup, but uses the FAILURE_ACTION env variable to skip errors from the experimental PHP configuration (8.0 for now).

cc @falkenhawk

@glensc
Copy link
Contributor Author

glensc commented Feb 8, 2021

This requires #58 to be merged first, as the ignore error is applied only to the phpunit run.

@glensc glensc marked this pull request as ready for review February 9, 2021 08:11
@falkenhawk
Copy link
Member

We should remove the experimental flag in actions/toolkit#32 then, right?

@glensc
Copy link
Contributor Author

glensc commented Feb 9, 2021

We should remove the experimental flag in actions/toolkit#32 then, right?

For 8.0 yes, but I would keep the "framework" in place for 8.1, or perhaps for 5.4/5.5 as those PHP builds are currently problematic.

The intent of the experimental: true is to say that we support them on a best effort basis, i.e they might work, but might have problems.

@falkenhawk falkenhawk merged commit 95958bc into zf1s:master Feb 9, 2021
@glensc glensc deleted the add-gha-8.0 branch February 9, 2021 12:32
@glensc glensc mentioned this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants