Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Update RestController to make it compatible with ZF 2.4.0 #64

Closed
wants to merge 2 commits into from

Conversation

weierophinney
Copy link
Member

ZF 2.4.0 adds a required $data parameter to AbstractRestfulController::deleteList(), which RestController extends. For 1.1, we must:

  • Update the minimum required ZF2 version to 2.4.0.
  • Update RestController::deleteList() to accept the new parameter, and pass it to the underlying resource.

@weierophinney
Copy link
Member Author

#59 makes RestController capable of receiving the $data parameter. However, the signature differs from what is present in ZF 2.4.0, as $data is required there. As such, the develop branch of zf-rest will need an update to be fully compatible with 2.4.

@weierophinney
Copy link
Member Author

Additionally, I cannot create a patch for this until 2.4.0 is stable, as we're not creating RC tags for the individual components.

Only in require-dev; will revert to use the original components as soon as 2.4.0
stable is released.
Per ZF 2.4.0. Several test cases that called `deleteList()` needed to be
updated to pass an argument to the method.
@weierophinney
Copy link
Member Author

Patch created, but should not be merged until after ZF 2.4.0 is released, and the original dependencies can be re-instated in the require-dev section of composer.json.

@TomHAnderson
Copy link
Contributor

zfcampus/zf-apigility-doctrine#156 will be on hold until ZF 2.4.0

@kusmierz
Copy link

kusmierz commented Apr 1, 2015

@TomHAnderson @weierophinney zf 2.4.0 is out, could you merge it, please?

@weierophinney
Copy link
Member Author

@kusmierz Patience. It'll happen soon enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants