Allowing for configurable default version #1
Conversation
|
@michaelmoussa Can you also do a similar PR against zfcampus/zf-apigility-admin for setting a default per-API? |
|
@weierophinney Sure. Is there anything else needed for this particular PR against |
|
@weierophinney WIP for It updates the configuration file already and everything. I just need to have the new default version value persist on the admin frontend between refreshes. That information is not presently available in the |
| @@ -15,6 +15,8 @@ | |||
| // Example: | |||
| // '#^application/vendor\.(?P<vendor>mwop)\.v(?P<version>\d+)\.(?P<resource>status|user)$#', | |||
| ), | |||
| // Default version number to use if none is provided by the API consumer. Default: 1 | |||
| 'default-version' => 1, | |||
There was a problem hiding this comment.
Use an underscore, not a dash here. (top-level, namespace keys use dash, otherwise, underscore-separated)
|
Looking good -- can you rebase your |
Allowing for configurable default version
|
Sure. Will take care of it late next week. Thanks for the merge. |
This change allows the API developer to choose which version should act as the default if none is specified in the URL or headers.
This is accomplished by setting
[zf-versioning][default-version]inmodule.config.php(which defaults to1). If this setting is omitted, then the existing default value of1in thePrototypeRouteListenerwill be used.I modified the
dataProviderin the test class to provide an optional$apiVersionto allow for testing various possibilities, such as:11"1as is done presently)