Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to preview DDS files #1

Open
JordyPKF opened this issue Jun 19, 2022 · 6 comments
Open

Unable to preview DDS files #1

JordyPKF opened this issue Jun 19, 2022 · 6 comments

Comments

@JordyPKF
Copy link

Opening .DDS files resulted in an error. When I commented out line 41 ( ip.Theme = context.Theme;) and line 50 (_ip.Theme = context.Theme;) of Plugin.cs it works for me.

@zhangkaihua88
Copy link
Owner

Hi JordyPKF, thank you for your feedback. Please sent me exception log (find here) and your Win-QL version, if you can. Because the ip.Theme code comes from the QuickLook.Plugin.ImageViewer. I want DDSViewer to have the same settings as ImageViewer. Therefore it 's error is maybe from ImageViewer.

@JordyPKF
Copy link
Author

JordyPKF commented Jun 22, 2022 via email

@JordyPKF
Copy link
Author

JordyPKF commented Jun 22, 2022 via email

@zhangkaihua88
Copy link
Owner

Hi, Jordy. I want to know your QuickLook version, I got same error in Version 3.6.9, 3.6.10 and 3.6.11 portable, and it works in 3.7.0 and 3.7.1. I think this error is version adaptation problem. If my guess is correct, please forgive me, I will not update the code.

========2022/6/24 11:00:42========
System.MissingMethodException: 找不到方法:“!!0 QuickLook.Common.Helpers.SettingHelper.Get(System.String, !!0, System.String)”。
在 QuickLook.Plugin.DDSViewer.Plugin.Prepare(String path, ContextObject context)
在 QuickLook.ViewerWindow.BeginShow(IViewer matchedPlugin, String path, Action`2 exceptionHandler)

Other evidence, these code is getting themes method in ImageViewer from different versions

// Version 3.6.11
context.Theme = (Themes) SettingHelper.Get("LastTheme", 1);
// Version 3.7.0
context.Theme = (Themes) SettingHelper.Get("LastTheme", 1, "QuickLook.Plugin.ImageViewer");

@zhangkaihua88
Copy link
Owner

Maybe I can add an exception handling for version 3.6.x.

@zhangkaihua88
Copy link
Owner

After trying to adapt to version 3.6.11, I found that it seems not easy. After adding exception handling, there will still be an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants