ssh: fix substitution when using experimental nix copy
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reasonable change, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the substitution (e.g.
cache.nixos.org) on remotes when deploying a flake-basedcolmenahive, which implies the use of the experimentalnix3 copy(since 7fac027).I consider this a UX bug in
nixand itsssh-ng://itself.I think this is because
ssh-ng://simply hasn't implemented--substitute-on-destinationyet.--builders-use-substitutesworks, however (NixOS/nix#4180).The old/legacy
ssh://does not have this issue withnix3 copy.I'll try to look a bit more into this in the future and will consider submitting a patch in upstream.
But for now, this patch should suffice.
Especially considering it will take quite some time until that patch is available in a new
nixrelease and installed on everyone's hosts :^)