Fix nullaware anti

zhejiangxiaomai · Apr 14, 2023 · 4ad47c1 · 4ad47c1
1 parent e21424d
commit 4ad47c1
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/velox/substrait/SubstraitToVeloxPlan.cpp b/velox/substrait/SubstraitToVeloxPlan.cpp
@@ -242,6 +242,7 @@ core::PlanNodePtr SubstraitVeloxPlanConverter::toVeloxPlan(
 
   // Map join type.
   core::JoinType joinType;
+  bool isNullAwareAntiJoin = false;
   switch (sJoin.type()) {
     case ::substrait::JoinRel_JoinType::JoinRel_JoinType_JOIN_TYPE_INNER:
       joinType = core::JoinType::kInner;
@@ -280,10 +281,9 @@ core::PlanNodePtr SubstraitVeloxPlanConverter::toVeloxPlan(
       if (sJoin.has_advanced_extension() &&
           subParser_->configSetInOptimization(
               sJoin.advanced_extension(), "isNullAwareAntiJoin=")) {
-        joinType = core::JoinType::kNullAwareAnti;
-      } else {
-        joinType = core::JoinType::kAnti;
+        isNullAwareAntiJoin = true;
       }
+      joinType = core::JoinType::kAnti;
       break;
     }
     default:
@@ -334,7 +334,7 @@ core::PlanNodePtr SubstraitVeloxPlanConverter::toVeloxPlan(
     return std::make_shared<core::HashJoinNode>(
         nextPlanNodeId(),
         joinType,
-        joinType == core::JoinType::kNullAwareAnti ? true : false,
+        isNullAwareAntiJoin,
         leftKeys,
         rightKeys,
         filter,