This repository has been archived by the owner on Jun 26, 2018. It is now read-only.
Bug fix for int value of "0" #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for int value = 0, and null not supported.
Fix for int value = 0, and throw exception for null values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The current implementation of
Toml::parseValue()was incorrectly setting int values of0tonull. This is becauseempty("0")(surprisingly) returnstrue. The fix is to check with strict equality with""instead.Also, I took the liberty to change the way the parser handles empty values. It is now throwing an
UnexpectedValueExceptionsince empty values are currently not allowed by the spec. And looking at the discussion on the issue page it doesn't seem likely it is going be allowed.I've also added the tests for these two changes.
Many thanks for your library by the way, and hope the fix is useful.
Best,
Laurent