Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't send empty string configs to ZLS where null would be expected #252

Merged
merged 2 commits into from
Dec 9, 2024
Merged

don't send empty string configs to ZLS where null would be expected #252

merged 2 commits into from
Dec 9, 2024

Conversation

Techatrix
Copy link
Collaborator

The extension would send config options with the value"" instead of null for options like zig_exe_path or global_cache_path. I also implemented a fix in ZLS

@Techatrix Techatrix mentioned this pull request Dec 9, 2024
Open
@Vexu Vexu merged commit 6bd864e into master Dec 9, 2024
2 checks passed
@Techatrix Techatrix deleted the techatrix/zls-config-middleware branch December 9, 2024 22:08
@Daskie Daskie mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techatrix @Vexu