Skip to content

Commit

Permalink
compiler: Remove warning about superfluous compiler-rt libraries.
Browse files Browse the repository at this point in the history
* This warning's wording is actually inaccurate when using the -fno-compiler-rt
  or -rtlib=none options.
* It's not all that helpful; it's already understood that these libraries are
  part of the compiler, so printing a warning is just noise. In practice, this
  warning would always happen when building upstream musl, for example.
* We don't warn when we satisfy -lunwind using our bundled libunwind either, or
  various libc libraries using our bundled libc, or when providing libc++, etc.
  So I really don't think we should be warning here either.
  • Loading branch information
alexrp committed Dec 6, 2024
1 parent a879c3e commit da794ec
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/main.zig
Original file line number Diff line number Diff line change
Expand Up @@ -3838,10 +3838,7 @@ fn createModule(
create_module.opts.link_libunwind = true;
continue;
},
.only_compiler_rt => {
warn("ignoring superfluous library '{s}': this dependency is fulfilled instead by compiler-rt which zig unconditionally provides", .{lib_name});
continue;
},
.only_compiler_rt => continue,
}

if (target.isMinGW()) {
Expand Down

0 comments on commit da794ec

Please sign in to comment.