Remove all usages of std.mem.copy and remove std.mem.set
#18143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Vexu for aro |
squeek502
reviewed
Nov 27, 2023
|
Just FYI, the typical procedure is to alias things with a |
|
For the CI failures, should I just change them all to |
|
The slices need to be the same length to use |
|
ah i see, they were just done using |
|
i know what to fix, i just wanna test a couple things tomorrow 😄 i wish there was a way for me to cancel ci actions, because i feel bad about wasting resources 😭 |
Vexu
approved these changes
Nov 27, 2023
Rexicon226
changed the title
std.mem.copystd.mem.copy and remove std.mem.set
voluntas
added a commit
to shiguredo/media-processors
that referenced
this pull request
Dec 9, 2023
linusg
added a commit
to linusg/zig-args
that referenced
this pull request
Jan 4, 2024
linusg
added a commit
to linusg/zig-args
that referenced
this pull request
Jan 4, 2024
linusg
added a commit
to linusg/zig-args
that referenced
this pull request
Jan 5, 2024
linusg
added a commit
to linusg/zig-args
that referenced
this pull request
Jan 5, 2024
ikskuh
pushed a commit
to ikskuh/zig-args
that referenced
this pull request
Jan 5, 2024
RossComputerGuy
pushed a commit
to ExpidusOS-archive/zig
that referenced
this pull request
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My reasoning for making this PR is 2 reasons.
This should have been simply removed/
@compileErrorthe first time, and now there is just no point in keeping it around.In my opinion this creates a bad practice function alias. By aliasing
copyForward, we are creating possible bugs that are not caught and corrupt data due to overlap. The pointer overlap detection of@memcpyis more important than I believe given credit to. So it leads to the thought that all uses ofstd.mem.copy(after it was aliased/depricated), were made out of ignorance of the dangerous it could pose to the codebase. If the writer wanted to ensure overlap, they would have / should usecopyForward, and if they did not want overlap, they need to use@memcpy.