Add std.zig.target.glibcRuntimeTriple() and use it in std.Build.Step.Run and process_headers.zig
#22090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These serve the same purpose as the linuxTriple() and linuxTripleSimple() functions, i.e. to return a triple understood by the GNU ecosystem.
This lets us centralize the logic for constructing a target triple that matches the format used by glibc's build-many-glibcs.py script.
alexrp
force-pushed
the
glibc-runtime-triples
branch
from
e3158e7 to
9293e04
Compare
|
Going to go ahead and merge this, but @andrewrk you might want to have a look at it post-merge at some point since I imagine the two of us are the main users of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main benefit to users from this change is that they no longer need to create a bunch of symlinks in the directory passed to
--glibc-runtimessince we now pick the right directory names.