Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a ubsan runtime for better error messages #22488

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

implement a ubsan runtime for better error messages #22488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
17c1137
ubsan: add a basic runtime
Rexicon226 Dec 17, 2024
69ccf1b
ubsan: switch to using `std.builtin.panicExtra` to log errors
Rexicon226 Dec 17, 2024
11f8425
Compilation: use the minimal runtime in `ReleaseSafe`
Rexicon226 Dec 18, 2024
f04a348
ubsan: implement some more checks
Rexicon226 Dec 25, 2024
c1c0d71
move libubsan to `lib/` and integrate it into `-fubsan-rt`
Rexicon226 Dec 26, 2024
cd05993
mem: add `@branchHint` to `indexOfSentinel`
Rexicon226 Dec 26, 2024
224f3ac
ubsan: implement more checks
Rexicon226 Dec 26, 2024
fcb73af
ubsan: extend `ptr` before adding to avoid overflow
Rexicon226 Dec 26, 2024
e65bdf8
ubsan: clean-up and remove the unused handlers
Rexicon226 Dec 26, 2024
f6904d4
ubsan: resolve the last of the TODOs
Rexicon226 Dec 26, 2024
e218322
Compilation: always import ubsan if a ZCU exists
Rexicon226 Dec 26, 2024
515476e
main: add `-f{no-}ubsan-rt` to the usage text
Rexicon226 Dec 26, 2024
6f58e22
ubsan: clean-up a bit more
Rexicon226 Dec 27, 2024
38f1c4d
build: add `bundle_ubsan_rt`
Rexicon226 Dec 27, 2024
2a08a56
Compilation: correct when to include ubsan
Rexicon226 Jan 1, 2025
a61b143
correct some bugs
Rexicon226 Jan 14, 2025
8da1898
build: add comments explaining why we disable ubsan
Rexicon226 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/std/Build/Step/Compile.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ compress_debug_sections: enum { none, zlib, zstd } = .none,
verbose_link: bool,
verbose_cc: bool,
bundle_compiler_rt: ?bool = null,
bundle_ubsan_rt: ?bool = null,
rdynamic: bool,
import_memory: bool = false,
export_memory: bool = false,
Expand Down Expand Up @@ -1557,6 +1558,7 @@ fn getZigArgs(compile: *Compile, fuzz: bool) ![][]const u8 {
}

try addFlag(&zig_args, "compiler-rt", compile.bundle_compiler_rt);
try addFlag(&zig_args, "ubsan-rt", compile.bundle_ubsan_rt);
try addFlag(&zig_args, "dll-export-fns", compile.dll_export_fns);
if (compile.rdynamic) {
try zig_args.append("-rdynamic");
Expand Down
1 change: 1 addition & 0 deletions lib/std/mem.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,7 @@ pub fn indexOfSentinel(comptime T: type, comptime sentinel: T, p: [*:sentinel]co

i += @divExact(std.mem.alignForward(usize, start_addr, block_size) - start_addr, @sizeOf(T));
} else {
@branchHint(.unlikely);
// Would read over a page boundary. Per-byte at a time until aligned or found.
// 0.39% chance this branch is taken for 4K pages at 16b block length.
//
Expand Down
Loading
Loading