move enableDynameField to options

zilliztech · Jul 11, 2024 · c74989e · c74989e
1 parent 5f6c253
commit c74989e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/...src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/catalog/MilvusCatalog.java b/...src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/catalog/MilvusCatalog.java
@@ -212,7 +212,11 @@ private void createIndexInternal(TablePath tablePath, List<VectorIndex> vectorIn
                             .withMetricType(MetricType.valueOf(index.getMetricType()))
                             .build();
 
-            client.createIndex(createIndexParam);
+            R<RpcStatus> response = client.createIndex(createIndexParam);
+            if (!Objects.equals(response.getStatus(), R.success().getStatus())) {
+                throw new MilvusConnectorException(
+                        MilvusConnectionErrorCode.CREATE_INDEX_ERROR, response.getMessage());
+            }
         }
     }
 
@@ -244,13 +248,12 @@ public void createTableInternal(TablePath tablePath, CatalogTable catalogTable)
             CreateCollectionParam createCollectionParam = builder.build();
             R<RpcStatus> response = this.client.createCollection(createCollectionParam);
             if (!Objects.equals(response.getStatus(), R.success().getStatus())) {
-                throw new CatalogException(
-                        String.format("Create collection failed, err=%s", response.getMessage()),
-                        response.getException());
+                throw new MilvusConnectorException(
+                        MilvusConnectionErrorCode.CREATE_COLLECTION_ERROR, response.getMessage());
             }
         } catch (Exception e) {
-            throw new CatalogException(
-                    String.format("Failed creating collection %s", tablePath.getFullName()), e);
+            throw new MilvusConnectorException(
+                    MilvusConnectionErrorCode.CREATE_COLLECTION_ERROR, e);
         }
     }
 

diff --git a/...org/apache/seatunnel/connectors/seatunnel/milvus/exception/MilvusConnectionErrorCode.java b/...org/apache/seatunnel/connectors/seatunnel/milvus/exception/MilvusConnectionErrorCode.java
@@ -33,6 +33,8 @@ public enum MilvusConnectionErrorCode implements SeaTunnelErrorCode {
     CLOSE_CLIENT_ERROR("MILVUS-11", "Close client error"),
     DESC_INDEX_ERROR("MILVUS-12", "Desc index error"),
     CREATE_DATABASE_ERROR("MILVUS-13", "Create database error"),
+    CREATE_COLLECTION_ERROR("MILVUS-14", "Create collection error"),
+    CREATE_INDEX_ERROR("MILVUS-15", "Create index error"),
     ;
 
     private final String code;