Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Konsti measurements #5

Merged
merged 49 commits into from
Jun 10, 2024
Merged

Konsti measurements #5

merged 49 commits into from
Jun 10, 2024

Conversation

KonstiNik
Copy link
Member

@KonstiNik KonstiNik commented May 10, 2024 •
edited
Loading

Implementation of measurements.

  • Implement and test the measurement base class
  • Implement default measurements
  • Write and test utils which the measurements are based on

knikolaou and others added 23 commits May 8, 2024 17:37
Include correct license in pyproject
2930a4a
Update gitignore to ignore specific vscode settings.
ff85c1c
Include header in existing files.
c445c4a
Create BaseMeasurement Class
5255ea7
@KonstiNik
Deactivate Black on PRs
0935135
@KonstiNik
- Write BaseMeasurement class work
149ad97 
Create a test for - BaseMeasurement
@KonstiNik
remove dummy test
05082db
@KonstiNik
add temporal test notebook
d1febf4
@KonstiNik
Start writing measurements
da09517
@KonstiNik
Start writing matrix utils and according tests
ec50534
@KonstiNik
remove file for entropy measurement
fd1fbdf
@KonstiNik
run black
a4d83e9
@KonstiNik
Fix signs in testing eigenspace computation
f1d1ad6
@KonstiNik
try fixing numpy installation
e9cb663
@KonstiNik
Fix missing numpy installation in developer mode
546b6fe
@KonstiNik
fix base_measurement test
d11195f
Write matrix utils
373e785
Implement analysis utils and tests
0454c87
remove unnessecary inputs from tests
845e79b
make kwargs of shannon and von neuman entropy similar
e47b92f
write default measurements
1ffb9e8
run isort
463a8a8
Write init for measurements
41c82ec
@KonstiNik KonstiNik requested a review from SamTov May 10, 2024 14:02
@KonstiNik KonstiNik mentioned this pull request May 10, 2024
Closed
knikolaou and others added 19 commits May 10, 2024 21:04
remove unused imports
4b63f0b
Add test for neural state keys
510ffb3
Add ntk to measurements
8c09782
Write
b7a3c4e 
- neural state
- neural state creator
fix pytest file search
3764ecb
@KonstiNik
Fix import issues
38e1bdf
remove print from tests
e6e8d66
Remove logging of clipping in eigenvalue calculation
8274786
rename function input to loss and accuracy
21722ac
remove unused parts from test_base_measurement
1736b7f
remove print statement from test_base_measurement
658fe50
Add shape check to BaseMeasurement class
e387616
Add shape checking to all ntk measurements
22c6cb6
Include NTK measurement in imports
8ca062b
@KonstiNik
write loss derivative measurement.
7e2184a
Remove the public kwarg from measurements
0300ab3
Merge branch 'Konsti_Measurements' of https://github.com/zincware/pap…
b54db51 
…yrus into Konsti_Measurements
remove public kwarg from loss derivative
fb30d6a
@SamTov
Update test_matrix_utils.py
777af32 
Removed print statement
SamTov
SamTov approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@SamTov SamTov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment regarding the utils being matrix utils and settling on Gram vs Grammian but otherwise, I am happy.

CI/unit_tests/utils/test_analysis_utils.py Outdated Show resolved Hide resolved
CI/unit_tests/utils/test_matrix_utils.py Outdated Show resolved Hide resolved
CI/unit_tests/utils/test_matrix_utils.py Outdated Show resolved Hide resolved
@KonstiNik KonstiNik merged commit e5b4af7 into main Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamTov SamTov SamTov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KonstiNik @SamTov