Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDataTypeFromString defined in 2 places in spark code #598

Closed
sonalgoyal opened this issue May 30, 2023 · 1 comment
Closed

getDataTypeFromString defined in 2 places in spark code #598

sonalgoyal opened this issue May 30, 2023 · 1 comment
Assignees
@vikasgupta78
Labels
good first issue to start contributing to Zingg

Comments

@sonalgoyal
Copy link
Member

spark block and sparkfeaturefactory both have this method. move to one common place
@sonalgoyal sonalgoyal added the good first issue to start contributing to Zingg label Mar 5, 2024
@vikasgupta78 vikasgupta78 mentioned this issue Aug 12, 2024
Merged
@vikasgupta78
Copy link
Contributor

pr raise both in OSS and enterprise

sonalgoyal added a commit that referenced this issue Aug 12, 2024
@sonalgoyal
Merge pull request #882 from vikasgupta78/issue598
3a25ca7 
dupe code removed issue #598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikasgupta78 vikasgupta78

Labels
good first issue to start contributing to Zingg
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sonalgoyal @vikasgupta78