-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObvDupe filter for ftd #692
Comments
Also move obvDupe to common class to be used by matcher and ftd |
Possible Impact on:
|
scenarios to be tested for ftd:
|
For scenario 2 i.e. Everything obv dupe i.e. no ftd left : It worked fine, no unmarked data created and following message when label run: It seems there are no unmarked records at this moment. Please run findTrainingData job to build some pairs to be labelled and then run this labeler. |
it should suggest to the user that it is unable to find any pairs as all pairs it sampled are part of the obvious duplicate condition |
We should do this in ftd stage? |
Added the message in TrainingDataFinder |
There is no impact on linker as linker is just extending from Matcher and all obv dupe related work is being handled by Matcher |
Issue #692 obv dupe changes for ftd and matcher
PR #694 Merged |
we dont want users to label what they already specify as obvious dupes
hypothetically if say all 100% records are filtered due to obv dupe
what would ftd do?
It would do nothing. print a message
The text was updated successfully, but these errors were encountered: