Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObvDupe filter for ftd #692

Closed
vikasgupta78 opened this issue Oct 17, 2023 · 9 comments
Closed

ObvDupe filter for ftd #692

vikasgupta78 opened this issue Oct 17, 2023 · 9 comments
Assignees

Comments

@vikasgupta78
Copy link
Contributor

vikasgupta78 commented Oct 17, 2023

  1. we dont want users to label what they already specify as obvious dupes

  2. hypothetically if say all 100% records are filtered due to obv dupe

    what would ftd do?

    It would do nothing. print a message

@vikasgupta78
Copy link
Contributor Author

Also move obvDupe to common class to be used by matcher and ftd

@vikasgupta78 vikasgupta78 self-assigned this Oct 17, 2023
@vikasgupta78
Copy link
Contributor Author

Possible Impact on:

  1. ZFrame
  2. SparkFrame
  3. TrainingDataFinder
  4. Matcher

@vikasgupta78
Copy link
Contributor Author

vikasgupta78 commented Oct 18, 2023

scenarios to be tested for ftd:

  1. No obv dupe data [but obv dupe condition there]
  2. Everything obv dupe i.e. no ftd left
  3. Some obv dupe
  4. No obv dupe condition there

@vikasgupta78
Copy link
Contributor Author

For scenario 2 i.e. Everything obv dupe i.e. no ftd left :

It worked fine, no unmarked data created and following message when label run:

It seems there are no unmarked records at this moment. Please run findTrainingData job to build some pairs to be labelled and then run this labeler.

@sonalgoyal
Copy link
Member

it should suggest to the user that it is unable to find any pairs as all pairs it sampled are part of the obvious duplicate condition

@vikasgupta78
Copy link
Contributor Author

We should do this in ftd stage?

@vikasgupta78
Copy link
Contributor Author

Added the message in TrainingDataFinder

@vikasgupta78
Copy link
Contributor Author

There is no impact on linker as linker is just extending from Matcher and all obv dupe related work is being handled by Matcher

sonalgoyal added a commit that referenced this issue Oct 22, 2023
Issue #692 obv dupe changes for ftd and matcher
@vikasgupta78
Copy link
Contributor Author

PR #694 Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants