TCs for String Similarity Distance function #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
navinrathore
commented
Jun 30, 2022
navinrathore
commented
- Used JaccSimFunction class for instanciation as StringSimilarityDistanceFunction is an abstract class.
- Added TC for specific sample strings as inputs.
sonalgoyal
requested changes
Jul 4, 2022
| public void testBothNotEmptyDifferent() { | ||
| StringSimilarityDistanceFunction strDistanceFn = new JaccSimFunction("test"); | ||
| Double score = strDistanceFn.call("sample text first", "sample text second"); | ||
| assertFalse(score == 0d || score == 1d); |
There was a problem hiding this comment.
add actual similarity as per jaccard
There was a problem hiding this comment.
Added actual values. Not sure the score values are correct, values are taken from secondstring output
| String second = "sample string/with slash:and,."; | ||
| Double score = strDistanceFn.call(first, second); | ||
| assertFalse(score == 0d || score == 1d); | ||
| } |
There was a problem hiding this comment.
please make the string smaller and put actual similarity by using set overlap
There was a problem hiding this comment.
Shorten the strings and actual score values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.