Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix passing options to loaders #187

Merged
merged 4 commits into from
Oct 28, 2017
Merged

fix passing options to loaders #187

merged 4 commits into from
Oct 28, 2017

Conversation

zinserjan
Copy link
Owner

fixes #127

Loaders does no longer have access to webpack config. That's why we need to pass all loader options directly to the loader.

@codecov-io
Copy link

codecov-io commented Oct 28, 2017

Codecov Report

Merging #187 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   96.77%   96.77%   -0.01%     
==========================================
  Files          28       28              
  Lines         745      744       -1     
==========================================
- Hits          721      720       -1     
  Misses         24       24
Impacted Files Coverage Δ
src/webpack/loader/entryLoader.js 100% <100%> (ø) ⬆️
src/runner/TestRunner.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7dd7b6...d99419b. Read the comment docs.

@zinserjan zinserjan merged commit a8e4329 into master Oct 28, 2017
@zinserjan zinserjan deleted the fix-undefined-get-files branch October 28, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property getFiles of undefined 1.0.0.beta.0/1
2 participants