Slf4j bridge #202
Merged
Slf4j bridge #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @vigoo for this PR it looks pretty good. |
pshemass
approved these changes
Jan 2, 2021
jdegoes
reviewed
Jan 2, 2021
| def attachRuntime(runtime: zio.Runtime[Logging]): Unit = | ||
| this.runtime = runtime | ||
|
|
||
| private[impl] def run[A](f: ZIO[Logging, Nothing, A]): Unit = |
There was a problem hiding this comment.
Delete the A type parameter and accept ZIO[Logging, Nothing, Any], instead. Clearer expression of the same idea.
jdegoes
reviewed
Jan 3, 2021
| } | ||
|
|
||
| object ZioLoggerFactory { | ||
| def bind(runtime: zio.Runtime[Logging]): Unit = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new module called
zio-logging-slf4j-bridge, which is the "opposite" of the existing SLF4j support, registeringzio-loggingas an SLF4j provider.With this third party libraries logging through SLF4j can log through zio-logging without the need to a third party slf4j implementation.
This is good for reducing dependencies and simplify the whole logging stack of services.
For example we are using this for mixing in sttp and Netty logs to the zio-logging log stream of a service.
Easy filtering configuration makes this much more usable, a proposed solution for that is coming in another PR.