Ensure log message laziness in Slf4jLogger with logging guards #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logging guards to prevent log message evaluation if current logger is disabled.
pshemass
approved these changes
Mar 1, 2021
|
@aartigao thanks for that fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logging guards to prevent log message evaluation if current logger is disabled.
Currently if you have a potentially expensive interpolated
Stringlike:where
$datums'stoStringis an expensive operation it gets evaluated even if the log level is disabled. This evaluation takes place at the boundary between Scala (ZIO Logging) and Java (SLF4J Logging).This PR prevents that by setting logging guards before SLF4J Logging invocation, making the operations in ZIO side truly lazy.