Json appender #458
Merged
Json appender #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jdegoes
previously approved these changes
Jun 26, 2022
|
@davidlar This is good to merge when you get a chance to fix conflicts! |
|
Great! I thought about reusing the string builder more instead of creating new ones. Don't know if it will affect performance or not. |
jdegoes
approved these changes
Jun 29, 2022
|
@davidlar Thanks for your persistence! We finally got this merged in. One of the main things, I think, would be using low-level 'while' loops and working directly with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rework of #424 after review by @jdegoes.