-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slf4j2 bridge #577
Merged
Merged
Slf4j2 bridge #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@justcoon Good to merge when conflicts resolved. 👍 |
justcoon
force-pushed
the
slf4j2_bridge
branch
from
December 29, 2022 17:29
5a9a3b1
to
3ef441b
Compare
justcoon
force-pushed
the
slf4j2_bridge
branch
3 times, most recently
from
January 23, 2023 19:35
70a4571
to
04260c7
Compare
justcoon
force-pushed
the
slf4j2_bridge
branch
from
January 23, 2023 19:39
04260c7
to
0894243
Compare
jdegoes
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #567
slf4j bridge for slf4j v2
few notes:
zio-logging-slf4j2-bridge
aszio-logging-slf4j-bridge
is for slf4j v1, do we want to change naming for modules? For example have zio-logging-slf4j-bridge for actual version - v2, and for v1 havezio-logging-slf4j1-bridge
or something elsecompileOrder := CompileOrder.JavaThenScala
setting (mentioned in sbt issue) worked, but in this case java classes, can not use scala classes, code was implemented in that way--module-path