-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #612 - implement LogFilter glob-like wildcard support #613
Feature #612 - implement LogFilter glob-like wildcard support #613
Conversation
Did some benchmarks to see if there is much performance loss. I did not extend the benchmark tests to include wildcard paths, only tested for regression for current supported structures. Feature #612
|
thank you for contribution |
Hmm, I see this library still needs to support older Scala versions for which the CI tests now fail 😞 |
hello @ThijsBroersen , hope you are doing well, are you planning to continue to work on this issue? thank you |
2695a28
to
bd4a8c7
Compare
bd4a8c7
to
0423f01
Compare
PR
Master
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you very much for contribution
#612
I implemented
**
(any number of paths) and*
(any (partial) path) within the existing LogFilter path structureList[String]
.I think this could be optimized if the LogFilters were used in a nested map-like structure.
Another way would be the use regex.