Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite the EOCD/EOCD64 detection to fix extreme performance regression #247

Merged
merged 23 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
605f243
fix: resolve clippy warning in nightly
RisaI Oct 20, 2024
1c00e11
wip: major rework of cde location
RisaI Sep 26, 2024
157da75
wip: rework CDE lookup
RisaI Sep 27, 2024
a982a59
refactor: magic finder, eocd lookup retry
RisaI Sep 27, 2024
15bd50a
wip: handle empty zips
RisaI Sep 27, 2024
91be415
fix: satisfy tests, add documentation
RisaI Sep 27, 2024
10ca275
chore: remove unused dependencies
RisaI Sep 27, 2024
9b5a987
feat: support both zip32 and zip64 comments
RisaI Sep 27, 2024
eed5788
feat: add zip64 comment functions to ZipWriter
RisaI Sep 27, 2024
5050e1f
fix: first pass on maintainer comments
RisaI Oct 20, 2024
63b959b
fix: continue searching for EOCD when the central directory is invalid
RisaI Oct 20, 2024
4e6700a
chore: satisfy clippy lints
RisaI Oct 20, 2024
0f7b326
chore: satisfy style_and_docs
RisaI Oct 20, 2024
37a431b
feat: support both directions in MagicFinder, correctly find first CDFH
RisaI Oct 20, 2024
eb0a2b8
fix: more checks to EOCD parsing, move comment size error from parse …
RisaI Oct 20, 2024
bc27ed0
fix: use saturating add when checking eocd64 record_size upper bound
RisaI Oct 20, 2024
1435707
fix: correctly handle mid window offsets in forward mode
RisaI Oct 20, 2024
3c04567
fix: compare maximum possible comment length against file size, not s…
RisaI Nov 5, 2024
8d542b6
feat: handle zip64 detection as a hint
RisaI Nov 5, 2024
300810f
fix: detect oversized central directories when locating EOCD64
RisaI Nov 5, 2024
24ad65f
fix: oopsie
RisaI Nov 5, 2024
50323d4
Merge branch 'master' into eocd_rewrite
Pr0methean Nov 19, 2024
b39a70e
Merge branch 'master' into eocd_rewrite
RisaI Nov 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading