Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authentication #271

Merged
merged 30 commits into from
Dec 19, 2023
Merged

feat: authentication #271

merged 30 commits into from
Dec 19, 2023

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Dec 7, 2023

Adds the ability to authenticate the user using OIDC/OAuth Authorization Code Flow to the ZITADEL SDK.

relates to zitadel/zitadel#5192

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date (additionally docs: add go authentication example zitadel#7034)
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9a4a21) 34.28% compared to head (8bddea5) 34.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #271   +/-   ##
=======================================
  Coverage   34.28%   34.28%           
=======================================
  Files           5        5           
  Lines         105      105           
=======================================
  Hits           36       36           
  Misses         66       66           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a marked this pull request as ready for review December 7, 2023 09:39
example/app/app.go Outdated Show resolved Hide resolved
pkg/authentication/middleware.go Show resolved Hide resolved
pkg/authentication/middleware.go Show resolved Hide resolved
example/app/app.go Show resolved Hide resolved
pkg/authentication/authenticate.go Show resolved Hide resolved
pkg/authentication/oidc/authenticate.go Show resolved Hide resolved
pkg/authentication/oidc/authenticate.go Outdated Show resolved Hide resolved
@livio-a livio-a requested a review from stebenz December 18, 2023 06:31
@livio-a livio-a merged commit 5eb9366 into next Dec 19, 2023
5 checks passed
@livio-a livio-a deleted the authentication branch December 19, 2023 10:19
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants