-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API client #280
Merged
feat: API client #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - remove pkg/api/middleware packages (Introspection middleware) - remove deprecated `WithKeyPath` client connection option
BREAKING CHANGES: NewClient functions require context.Context remove deprecated `WithKeyPath` client connection option
# Conflicts: # example/api/http/main.go # go.mod # go.sum # pkg/authorization/check_test.go # pkg/authorization/error.go # pkg/authorization/oauth/authorizer.go # pkg/client/system/client.go # pkg/zitadel/zitadel.go
# Conflicts: # example/api/http/main.go # example/app/app.go # pkg/authentication/authenticate.go # pkg/authentication/oidc/authenticate.go # pkg/zitadel/zitadel.go
1 task
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #280 +/- ##
==========================================
- Coverage 34.28% 34.25% -0.03%
==========================================
Files 5 5
Lines 105 108 +3
==========================================
+ Hits 36 37 +1
- Misses 66 68 +2
Partials 3 3 ☔ View full report in Codecov by Sentry. |
stebenz
approved these changes
Dec 20, 2023
🎉 This PR is included in version 2.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use the ZITADEL API on a single client / connection.
relates to zitadel/zitadel#5192
To be able to initialize the SDK with more than a single ability (authN, authZ, API client) at once, the idea of providing options to the
Zitadel
provider had to be discarded. It would have taken to much effort to handle all cases of generic types.The current idea is to provide a general configuration of Zitadel to the different parts, so that e.g. the authZ package can build the necessary issuer from the domain and the client can use it to connect to the API.
Definition of Ready