gh-pages build on push, not release

[tjex]

The gh pages fix from #387 setup deployment / build to occur on release publishing.

The documentation / readme is therefore stuck until the next zk semver release.

I think it's better to have the page rebuild on push / merge, as documentation updates are seemingly frequent.

@hugginsio what do you think?

[tjex]

Looks like it's not as simple as changing to on-push.
https://github.com/zk-org/zk/actions/runs/9860060569/job/27225298529?pr=430

[hugginsio]

Hi @tjex - nice catch!

My reasoning behind only rebuilding on release was so that documentation doesn't get out of sync with the application features. I believe this could be extended to also include pattern matching so that README updates trigger a rebuild.

There might be a place for that down the road, but while documentation gets updated (and maybe eventually overhauled) rebuilding the site on every push is probably better.

[hugginsio]

Looks like it's not as simple as changing to on-push. https://github.com/zk-org/zk/actions/runs/9860060569/job/27225298529?pr=430

That is an unusual error... especially considering we have the id-token set properly, same as the examples?

zk/.github/workflows/gh-pages.yml

Lines 8 to 11 in 739d2d4

	permissions:
	contents: read
	pages: write
	id-token: write

Did anyone make changes to the Actions settings at the organization level since we last deployed to Pages?

[tjex]

Not at the organisation level. We actually never had any secrets / tokens at the org level.
The only time I remember talking about secrets was here: #419 (comment)

But it was to do with homebrew.

Thing is, apart from the homebrew secret. We don't have any other tokens...?
There's also no environment secrets set for the gh-pages environment settings in settings -> environments

So I'm actually a bit confused how pages even deployed in the first place 🫤

[mcDevnagh]

we shouldn't deploy on PR. Only if main is updated

[mcDevnagh]

https://github.com/zk-org/zk/actions/runs/9895195879
success

[tjex]

Great work all! That was a snappy turn around 💫