Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tron deploy beta #2

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Tron deploy beta #2

wants to merge 17 commits into from

Conversation

AllFi
Copy link

@AllFi AllFi commented Dec 18, 2023 •
edited by r0wdy1
Loading

In this pull request (PR), the following changes were made:

  • The existing code was refactored slightly to reduce the amount of duplicated code.
  • The code was modified to wait for transactions to be confirmed.
  • Proof verification code was commented out.
  • MPCGuard was added.

TODO:

  • Update MPC Guard after the review
  • Check that pool contract is relevant
  • Move pool parameters (limits, etc.) to envs
  • Add asserts

k1rill-fedoseev
k1rill-fedoseev reviewed Dec 24, 2023
View reviewed changes
contracts/src/zkbob/ZkBobPool.sol Show resolved Hide resolved
migrations/2_pool_impl.js Show resolved Hide resolved
migrations/1_initial_migration.js Outdated Show resolved Hide resolved
migrations/3_pool.js Show resolved Hide resolved
akolotov
akolotov requested changes Dec 27, 2023
View reviewed changes
migrations/3_pool.js Outdated Show resolved Hide resolved
@r0wdy1 r0wdy1 marked this pull request as ready for review December 27, 2023 22:01
@r0wdy1 r0wdy1 requested a review from akolotov January 10, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1rill-fedoseev k1rill-fedoseev k1rill-fedoseev left review comments

@r0wdy1 r0wdy1 Awaiting requested review from r0wdy1

@akolotov akolotov Awaiting requested review from akolotov

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllFi @akolotov @k1rill-fedoseev @r0wdy1 @YusupovAI