Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delegated deposit #53

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix delegated deposit #53

merged 1 commit into from
Feb 17, 2023

Conversation

AllFi
Copy link

@AllFi AllFi commented Feb 16, 2023 •
edited
Loading

Problems:

  1. DD is displayed in the history of all users:
    image

@akolotov
Copy link

@AllFi who would you suggest for review? Should it go to the main branch eventually together with the recent changes in libzeropool?

@AllFi
Copy link
Author

AllFi commented Feb 17, 2023 •
edited
Loading

@AllFi who would you suggest for review? Should it go to the main branch eventually together with the recent changes in libzeropool?

Anyone free will do, the change is quite simple. Yes, I think it should.

EvgenKor
EvgenKor approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@EvgenKor EvgenKor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes are correct

@akolotov akolotov merged commit c1410ef into develop Feb 17, 2023
@akolotov akolotov deleted the fix/delegated_deposit branch February 17, 2023 10:47
EvgenKor added a commit that referenced this pull request Feb 17, 2023
@EvgenKor @AllFi
Develop (#55)
704402d 
* Avoid handling direct deposits in the history of non-recipients (#53)

* Add Helpers.isInPrimeSubgroup (#54)

* Add Helpers.isInPrimeSubgroup

* Improving zk address checking

* Changing libzeropool dependency to libzeropool-zkbob

* Node lib core dependency updating

---------

Co-authored-by: EvgenKor <[email protected]>

---------

Co-authored-by: Alexander Filippov <[email protected]>
@akolotov akolotov mentioned this pull request Feb 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvgenKor EvgenKor EvgenKor approved these changes

@akolotov akolotov Awaiting requested review from akolotov

@k1rill-fedoseev k1rill-fedoseev Awaiting requested review from k1rill-fedoseev

@lok52 lok52 Awaiting requested review from lok52

@r0wdy1 r0wdy1 Awaiting requested review from r0wdy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllFi @akolotov @EvgenKor