Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for permit2 scheme #85

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Added support for permit2 scheme #85

merged 7 commits into from
Jun 22, 2023

Conversation

EvgenKor
Copy link

Updated with the latest changes of the client library to support new deposit schemes. CLI changes:

  • old method to perform deposit via approval deposit-shielded was removed
  • deposit-shielded-permittable was renamed to deposit-shielded
  • deposit-shielded-permittable-ephemeral was renamed to deposit-shielded-ephemeral

Associated library PR: zkBob/zkbob-client-js#140

@EvgenKor EvgenKor requested a review from k1rill-fedoseev June 21, 2023 13:52
src/account.ts Outdated Show resolved Hide resolved
Copy link

@AllFi AllFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the bug in the get-balance function, everything looks good to me.

@EvgenKor EvgenKor merged commit 3193baa into develop Jun 22, 2023
@EvgenKor EvgenKor deleted the feature/permit2 branch June 22, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants