New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix daily limits reset #25

Merged

akolotov merged 1 commit into master from fix-limits-reset-bug

Oct 29, 2022

Collaborator

k1rill-fedoseev commented Oct 29, 2022

The current codebase contains a bug that prevents proper daily deposit/withdrawal limit reset during a new day transition:

When the new day starts with a deposit operation, only daily deposit limit would be reset
When the new day starts with a withdrawal operation, only daily withdrawal limit would be reset
When the new day starts with a transfer operation, none of the daily limits would be reset

This PR fixes that and adds a regression test.


          Fix reset of daily limits

f5925fe

k1rill-fedoseev requested a review from akolotov

October 29, 2022 10:20

k1rill-fedoseev self-assigned this

akolotov approved these changes

View reviewed changes

akolotov merged commit a1ce123 into master

akolotov deleted the fix-limits-reset-bug branch

October 29, 2022 11:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet