Fix executeRecovery re-entrancy #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1rill-fedoseev
force-pushed
the
audit/dec22/5.1
branch
from
9b3b5af to
b909d1c
Compare
akolotov
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
executeRecoveryfunction inERC20Recoverycan only be called by the owner or the recovery admin. When recovering the tokens, they are transferred to therecoveredFundsReceiveraddress. If this address is a contract, theonTokenTransferfunction is called. This call could be used to reenter theexecuteRecoveryfunction in order to double-claim the funds to recover. This would allow the recovery admin or the owner to exceed the intendedrecoveryLimit.Comments to changes:
The order of storage writings for recovery execution flow was changes, so that the are now executed before respected receiver callback.