Explicit storage slot to keep KycProvidersManager #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1rill-fedoseev
approved these changes
Feb 22, 2023
akolotov
added a commit
that referenced
this pull request
Feb 23, 2023
This merge contains the following set of changes: - Add per-collateral limits (#52) - Update getAmountOut/getAmountIn estimation (#53) - Introduction of direct deposits (#49) - Support of KYCed accounts in limits management (#54) - Explicit storage slot to keep KycProvidersManager (#57) - Add verifiers for direct deposits (5bfd34d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach was chosen to avoid storage slots re-arrangement that could happen after upgrade to the new implementation of zkBOB pool.
It suggests to dedicate the slot
0x06c991646992b7f0f3fd0c832eac3f519e26682bcb82fbbcfd1ff8013d876f64to keep the KYC Providers Manager contract address.