[Dev Tools] forge test --zksync fails when deploying 3 contracts inside a prank

[coffeexcoin]

Team or Project

Abstract

Environment

Testnet

Select the Dev Tool you are using

Foundry

Provide the version of the tool (if applicable)

forge 0.0.2 (1b49d91 2025-01-11T00:32:40.171777000Z)

Provide a brief description of the functionality you're trying to implement and the issue you are running into.

When deploying 3 contracts inside a prank, forge test --zksync fails with [FAIL: custom error 0x9e4a3c8a: 010000193c09d210230db8aa75703d9788e2cb2a4fb6dd2a69b641e7256be9ee]

Deploying 3 contracts without a prank succeeds
Deploying 2 contracts in a prank succeeds
forge test without the --zksync flag succeeds

Minimal repro:
https://github.com/coffeexcoin/foundry-zksync-create-prank-error-repro

Repo Link (Optional)

https://github.com/coffeexcoin/foundry-zksync-create-prank-error-repro

Additional Details

No response

[popzxc]

Hey! I've done some research, and this error corresponds to the HashIsNonZero error, which occurs when the contract is being deployed to the same slot as previously.

It shouldn't happen normally due to deployment nonces, but looks like during the execution the nonce (neither "normal" or "deployment") is not incremented, e.g. the following code:

        uint256 nonce = vm.getNonce(owner);
        console.log("account_nonce", nonce);
        counter2 = new Counter();
        console.log("counter2", address(counter2));
        uint256 nonce2 = vm.getNonce(owner);
        console.log("account_nonce", nonce2);

gives us

  owner 0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38
  counter 0xb730F1C602804a67b453A3D28e8Cc4eD0A7eF90b
  account_nonce 3
  counter2 0x9d6E8AEB67E93a70Cf6aCDcaf49dF805903A6109
  account_nonce 3

This seems to be related to this logic -- we conditionally decide whether to increment the nonce for applied calls. If I change persist_nonce_update with true in this function, the tests will pass. Given that we allow persisting nonce updates for broadcast, a wild hypothesis would be that we have to allow it for pranks too? However, I don't know the codebase well enough to say for sure.

I will pass this to the foundry team and we will investigate.

[popzxc]

As an update: the foundry-zksync team is working on this issue.

[dutterbutter]

I just ran this again and it looks like this has been semi-fixed in matter-labs/foundry-zksync#839. I say "semi" as the tests now pass but we are logging out a stream of logs that show as an error while it shouldn't. Will follow up once we correct those logs but tests are now passing ✅ .

[dutterbutter]

Error output resolved in matter-labs/foundry-zksync#873 will be made available in next release v0.0.5