Switching out atty?

[Porges]

Would you accept a PR to switch out atty for something else? This would also affect supports_unicode and supports_hyperlinks.

There’s been an audit failure on atty for a while now which requires explicit suppression if you’re using something like cargo-audit or cargo-deny.

As to replacements, is-terminal seems to have been picked up by several projects such as clap.

[zkat]

yes, I've already accepted a PR to supports-color to make this change, so I'm happy to take PRs for the other three.

[Porges]

Opened:

• Switch from atty to is-terminal supports-hyperlinks#3
• Switch from atty to is-terminal supports-unicode#4

I also put a comment on the supports-color PR to suggest removing the indirection through the Stream type and instead expose the function for any IsTerminal to make it more generally useful. If you think that's a good idea I can open a PR to do that.

[gavrilikhin-d]

Should this issue be closed?

[Porges]

std::io::IsTerminal landed in 1.70.0, so we could now also drop the is-terminal dependencies.

I've opened (apparently consistency is not my strong suit):

• Switch to std::io::IsTerminal supports-unicode#5
• Use std::io::IsTerminal instead of is-terminal. supports-hyperlinks#4
• Replace is-terminal with std::io::IsTerminal supports-color#11

The API could now also be broadened to accept any std::io::IsTerminal instead of the Stdout/Stderr enum. This should probably be a different issue.

[zkat]

Thanks for these PRs. I'm gonna take care of this sometime soon, since it involves a coordinated release of several semver-major versions, and also is gonna bump miette's MSRV to 1.70.0, which I'm not sure I want to do right now?

[Nahor]

This can be closed now (fixed in e5c7ae4)