Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace is-terminal with std::io::IsTerminal #11

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

Porges
Copy link
Contributor

@Porges Porges commented Jun 7, 2023

This removes the is-terminal dependency but raises MSRV to 1.70.0.

@jszwedko
Copy link

I just ran into this today too since supports-color is currently affected by GHSA-g98v-hv3f-hcfr via the dependency on atty. Any chance this could be merged?

@Porges
Copy link
Contributor Author

Porges commented Oct 27, 2023

@jszwedko supports-color doesn't depend on atty since 2.0.0

@zkat
Copy link
Owner

zkat commented Oct 27, 2023

I'm gonna keep this around, but i don't want to bump the MSRV quite yet. That's a pretty high MSRV.

@jszwedko
Copy link

@Porges doh, apologies, I missed that we were still on an old version (via a transitive dependency). Thanks for clarifying!

@zkat
Copy link
Owner

zkat commented Feb 4, 2024

It is time ⏲️

@zkat zkat merged commit 6fb6e35 into zkat:main Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants