fix(chain): correct Chain structure exported
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes all current complier and clippy warnings.
zkat
reviewed
Jan 8, 2022
src/lib.rs
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| pub use miette_derive::*; | |||
|
|
|||
| pub use chain::*; | |||
There was a problem hiding this comment.
Yes, I think exporting named opaque type in chain method is better than returning a private type.
Alternative is to change chain to return impl Something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all current compiler and clippy warnings.
It looks like wrong
Chaintype was exported. This is technically could be seemed as a breaking change, but in reality should not break anyone since that type was not used and could not be created I think.