fix(colors): treat no-color mode as no-color instead of narratable #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
force-pushed
the
zkat/no-color-only-no-color
branch
from
9dcdeac to
f5fdadc
Compare
Fixes: #93 BREAKING CHANGE: NO_COLOR no longer triggers the narrated handler. Use NO_GRAPHICS instead.
zkat
force-pushed
the
zkat/no-color-only-no-color
branch
from
f5fdadc to
d714b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start, but I still want to add an environment variable to force "plaintext" mode. Maybe just "MIETTE_PLAINTEXT" or "PLAINTEXT_ERRORS"?
I'll sleep on it. Any opinions are welcome, tho.
Note that this PR is a breaking change, because some users possibly rely on this behavior to even be able to read their output.