Add structures for EDNS and NSID option #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added some structures and tests to show data included in EDNS such as client subnet (source scope filled by the resolver), NSID, and extended DNS errors. Now this information appears in the result JSON object in this form:
results in:
{"data":{"additionals":[{"ede":{"error_text":"DNSKEY Missing","extra_text":"no SEP matching the DS found for dnssec.fail.","info_code":9},"flags":"","type":"EDNS0","udpsize":1232,"version":0}],"protocol":"udp","resolver":"1.1.1.1:53"},"name":"dnssec.fail","status":"SERVFAIL","timestamp":"2023-07-01T10:00:00+00:00"}Feel free to accept this pull request if you think it would be appreciated.