Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated temporary error #377

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Remove deprecated temporary error #377

merged 2 commits into from
Jun 5, 2024

Conversation

phillip-stephens
Copy link
Contributor

The docs for net.Error say that Temporary() is deprecated and to not use it as its unreliable.

This PR removes that and STATUS_NOTIMP and STATUS_NODATA as they're used no-where in our codebase.

Changes

  • Remove use of Temporary()
  • Remove 2 un-used statuses

@phillip-stephens phillip-stephens marked this pull request as ready for review June 5, 2024 21:59
@phillip-stephens phillip-stephens requested a review from a team as a code owner June 5, 2024 21:59
@zakird zakird merged commit 9635bda into main Jun 5, 2024
3 checks passed
@zakird zakird deleted the phillip/remove-temporary branch June 5, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakird zakird zakird approved these changes

Assignees

@zakird zakird

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillip-stephens @zakird