Avoid changing the timeouts selected by user, better handling of iteration timeout and normal timeout #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363
Changes
IterativeResolution
in resolver config since we have separate methods and keep it only in the CliConf struct--timeout
and--iteration-timeout
Exchange...Context
functions inzmap/dns
to pass the timeout context in and get the advantage of failing fast here.iterativeLookup
Testing
Was a bit difficult to test, but added a
time.Sleep(time.Second)
into the lookup section of the code and alternated between--timeout 1
and--iteration-timeout 1
to see what error was returned.Note - The
status
is correctly reported`