Add integration tests for timestamps and --nanoseconds resolution timestamps
#390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+949
to
+971
|
|
||
| def test_timetamps(self): | ||
| c = "A" | ||
| name = "zdns-testing.com" | ||
| cmd, res = self.run_zdns(c, name) | ||
| self.assertSuccess(res, cmd) | ||
| assert "timestamp" in res | ||
| date = datetime.datetime.strptime(res["timestamp"], "%Y-%m-%dT%H:%M:%S%z") | ||
| self.assertTrue(date.microsecond == 0) # microseconds should be 0 since we didn't call with --nanoseconds | ||
|
|
||
| def test_timetamps_nanoseconds(self): | ||
| c = "A --nanoseconds" | ||
| name = "zdns-testing.com" | ||
| cmd, res = self.run_zdns(c, name) | ||
| self.assertSuccess(res, cmd) | ||
| assert "timestamp" in res | ||
| date = parser.parse(res["timestamp"]) | ||
| self.assertTrue(date.microsecond != 0) | ||
| # microseconds should be non-zero since we called with --nanoseconds. There is a chance it happens to be 0, | ||
| # but it is very unlikely. (1 in 1,000,000). Python's datetime.date's smallest unit of time is microseconds, | ||
| # so that's why we're using this in place of nanoseconds. It should not affect the test's validity. | ||
|
|
||
|
|
There was a problem hiding this comment.
Note to reviewers: apologies for the large change-set, my IDE auto-formatter decided to format the file according to PEP 8. These are the only functional, non-format changes
zakird
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134