-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for user to select root servers for iterative mode #412
Conversation
src/cli/config_validation.go
Outdated
@@ -75,6 +75,7 @@ func populateNetworkingConfig(gc *CLIConf) error { | |||
log.Info("using local interface: ", gc.LocalIfaceString) | |||
} | |||
|
|||
// TODO this now needs re-work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need resolution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch, looked back over this and yeah this needed addressing.
In the case that there was a loopback NS in /etc/resolv.conf
, without the check added in a2ada2c, ZDNS would over-write the nameservers.
Added a guard and tested by setting my local /etc/resolv.conf
to loopback. The old code overwrites the nameservers, with the guard added we don't and it performs as expected.
Description
A user may want to select a set of root name servers other than the full 13
.
roots, either to only use one root or to test against a different server. This PR adds that.Testing
When selecting a root server, ZDNS uses it
Notice how we start the lookup against the 1 root provided.
Normal usage isn't broken